Repository navigation
Conversation
Owner
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the full
react-markdowndependency from the shared application path used by style-property documentation.Docnow uses a small dependency-free React renderer for the Markdown features present in the MapLibre style specification: paragraphs, links, images, inline code, emphasis, lists, fenced code blocks, blockquotes, and thematic breaks.Agent messages keep using
react-markdownwithremark-gfm. BecauseModalAgentWorkspaceis already loaded through the existing async boundary, both the workspace and its chat Markdown implementation are now contained in the same async Agent chunk. This avoids a second Markdown renderer request when the workspace becomes available.Size comparison
Compared with
main, the shareddatasetchunk decreases from 153.02 kB to 37.62 kB raw, and from 47.88 kB to 13.28 kB gzip.The entry bundle grows slightly from 2,429.57 kB to 2,434.59 kB raw because the lightweight renderer is now part of the entry. However, the entry plus the JavaScript files listed as
modulepreloadinindex.htmldecreases from about 2,739.96 kB to 2,629.58 kB raw, and from 762.79 kB to 729.82 kB gzip. That is a reduction of about 110.38 kB raw and 32.97 kB gzip on the critical initial JavaScript path.The async Agent chunk grows from 92.48 kB to 207.50 kB raw, and from 26.40 kB to 60.44 kB gzip. It now includes the full Agent Markdown stack, so chat Markdown is ready when the Agent workspace chunk finishes; no separate
react-markdownchunk is emitted.Validation
npm run lintnpm run lint-cssnpm run test-unit— 21 files, 108 tests passed